[wp-trac] [WordPress Trac] #31467: Images should default to not linking

[WordPress Trac]

#31467: Images should default to not linking
---------------------------------+-----------------------------
 Reporter:  melchoyce            |       Owner:  wonderboymusic
     Type:  enhancement          |      Status:  assigned
 Priority:  normal               |   Milestone:  4.4
Component:  Media                |     Version:
 Severity:  normal               |  Resolution:
 Keywords:  make-flow has-patch  |     Focuses:  ui
---------------------------------+-----------------------------

Comment (by azaozz):

 Looking at 31467.diff, there is no point in doing
 {{{
 getUserSetting( 'align', 'none' ) || defaultProps.align
 }}}

 `getUserSetting()` takes two args: the setting's name and default value.
 If it's not set, it will return the default value, and
 `defaultProps.align` can never be reached.

 If we still want to use `defaultProps.align` as default value, can
 probably do:
 {{{
 getUserSetting( 'align', defaultProps.align )
 }}}

 assuming it is set to something.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31467#comment:27>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform