[wp-trac] [WordPress Trac] #33406: Creating a new user without a password causes error message issues

[WordPress Trac]

#33406: Creating a new user without a password causes error message issues
--------------------------+---------------------------------
 Reporter:  morganestes   |       Owner:  chriscct7
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  4.3.1
Component:  Users         |     Version:  4.3
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:  ui, administration
--------------------------+---------------------------------

Comment (by adamsilverstein):

 I tested [attachment:33406.patch] and while this does move the error icon
 to the correct location, I agree with @chriscct7 it does completely
 resolve the ticket - it does not fix the other issue: the error icon
 doesn't go away once you enter a password like it does with the username
 and email fields. Also, testing with show/hide on/off gave me different
 results.

 What's happening is the validation JavaScript is hooked to the original
 password field, while what you are editing is the text version of field -
 a copy we maintain to achieve Internet Explorer 8 compatibility (IE 8
 considers the type property read only, so the field can't be changed from
 password to text). You can see this by switching to the password view and
 trying your test again...  [http://cl.ly/image/190l0u07183p screencast].

 To fix: Maybe we can add a validation failure class to the wrapper, then
 use css to apply the styling to the currently visible field? Also: the
 callbacks that clear the error status when you enter a password need to be
 tied to both fields or trigger on the pw-changed event.

 @liljimmi  - would you like to try working on a revamped patch?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33406#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform