[wp-trac] [WordPress Trac] #33411: remove_panel('nav_menus') action generates errors

[WordPress Trac]

#33411: remove_panel('nav_menus') action generates errors
---------------------------------+-----------------------------------------
 Reporter:  IstanbulMMV          |       Owner:
     Type:  defect (bug)         |      Status:  new
 Priority:  normal               |   Milestone:  4.3.1
Component:  Customize            |     Version:  4.3
 Severity:  normal               |  Resolution:
 Keywords:  needs-patch 2nd-     |     Focuses:  javascript, administration
  opinion                        |
---------------------------------+-----------------------------------------

Comment (by DrewAPicture):

 While balancing that we don't necessarily want to encourage people to
 remove core panels from the Customizer, I don't think we need to make it
 intentionally difficult either. I would expect `remove_panel()` to do what
 it implies – completely remove the panel from the equation. And that
 should go for any panel, realistically, core or not.

 Having to unhook seven actions to accomplish what the method should
 already be capable of is not the kind of approach I think we should be
 promoting.

 Consider for a moment that when the Toolbar was introduced (as the 'admin
 bar') in 3.1, a short-circuit filter was included to kill it on the front-
 end. I'm not suggesting we use filters in this context, but I am
 suggesting that this should easier.

 If removing the panel or the section or the control from the array isn't
 enough, then maybe we need to look at a more comprehensive "unhooking"
 mechanism.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33411#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform