[wp-trac] [WordPress Trac] #33428: Toggling customizer controls based on another control does not work anymore in 4.3

[WordPress Trac]

#33428: Toggling customizer controls based on another control does not work anymore
in 4.3
--------------------------+--------------------------
 Reporter:  maimairel     |       Owner:  westonruter
     Type:  defect (bug)  |      Status:  accepted
 Priority:  normal        |   Milestone:  4.3.1
Component:  Customize     |     Version:  4.3
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  javascript
--------------------------+--------------------------

Comment (by westonruter):

 I've identified that the regression was introduced in [33610] to fix
 #33220.

 Specifically, the regression was caused by this change:

 {{{#!diff
 --- a/src/wp-admin/js/customize-controls.js
 +++ b/src/wp-admin/js/customize-controls.js
 @@ -2603,7 +2624,11 @@
                                 _( constructs ).each( function (
 activeConstructs, type ) {
                                         api[ type ].each( function (
 construct, id ) {
                                                 var active = !! (
 activeConstructs && activeConstructs[ id ] );
 -                                               construct.active( active
 );
 +                                               if ( active ) {
 +
 construct.activate();
 +                                               } else {
 +
 construct.deactivate();
 +                                               }
                                         } );
                                 } );
                         } );
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33428#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform