[wp-trac] [WordPress Trac] #32223: Hooks in wp_publish_post fire in an unnatural order

WordPress Trac noreply at wordpress.org
Mon Aug 24 02:55:23 UTC 2015


#32223: Hooks in wp_publish_post fire in an unnatural order
-------------------------------+----------------------
 Reporter:  Clorith            |       Owner:
     Type:  enhancement        |      Status:  closed
 Priority:  normal             |   Milestone:
Component:  Posts, Post Types  |     Version:  2.3
 Severity:  normal             |  Resolution:  wontfix
 Keywords:  has-patch          |     Focuses:
-------------------------------+----------------------
Changes (by DrewAPicture):

 * keywords:   => has-patch
 * status:  new => closed
 * type:  defect (bug) => enhancement
 * resolution:   => wontfix
 * milestone:  Awaiting Review =>


Comment:

 Replying to [ticket:32223 Clorith]:
 > This ordering has existed for some time though, so do we fix it, or
 leave it?
 >
 > I'm not seeing any obvious drawbacks to making the transition call be
 the final step in publishing a post, it feels like a more natural
 progression.
 >
 > Attached patch does just that, it moved the query to update post status,
 the cache clear and the transition call to run after we're done saving our
 post data

 I think it's definitely too late to be changing the order around. It's
 quite reasonable to think that many developers are counting on these hooks
 to fire in their current order. Closing as wontfix.

 Thank for the patch!

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32223#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list