[wp-trac] [WordPress Trac] #33417: JS error when uploading small image as Site Icon and electing to Skip Cropping
WordPress Trac
noreply at wordpress.org
Sun Aug 23 14:28:47 UTC 2015
#33417: JS error when uploading small image as Site Icon and electing to Skip
Cropping
--------------------------+-------------------------
Reporter: truonght | Owner: obenland
Type: defect (bug) | Status: accepted
Priority: normal | Milestone: 4.3.1
Component: Customize | Version: 4.3
Severity: normal | Resolution:
Keywords: needs-patch | Focuses: javascript
--------------------------+-------------------------
Comment (by tyxla):
With the current implementation, if there is an image with the size
`site_icon-32`, it is used. If there is no image with that size, the
`thumbnail` size is used. In case the image is smaller than `thumbnail`,
it has only `full` size, which we should use in this case. So I suggest
that we check for all of these sizes and finally the `full` size for this
edge case. Patch coming up soon.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/33417#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list