[wp-trac] [WordPress Trac] #33485: $deleted_term in wp_delete_term() has incorrect `count` value
WordPress Trac
noreply at wordpress.org
Sat Aug 22 20:06:35 UTC 2015
#33485: $deleted_term in wp_delete_term() has incorrect `count` value
--------------------------------------+--------------------------
Reporter: danielbachhuber | Owner: nicholas_io
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 4.4
Component: Taxonomy | Version:
Severity: normal | Resolution: fixed
Keywords: good-first-bug has-patch | Focuses:
--------------------------------------+--------------------------
Comment (by boonebgorges):
Replying to [comment:9 nicholas_io]:
> Replying to [comment:7 boonebgorges]:
> > Thanks, nicholas_io! Patch looks good. I'm going to reconfigure the
unit test a little bit to (a) make it compatible with PHP 5.2, and (b)
keep the assertions in the scope of the main test method rather than the
'wp_delete_term' callback (which is how we do it elsewhere in the test
suite).
>
> Great, I was in doubt about how do test inside callbacks, now I
understood how is done.
Your technique was good too, I'm just trying to be consistent :) Thanks
again for the patch!
--
Ticket URL: <https://core.trac.wordpress.org/ticket/33485#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list