[wp-trac] [WordPress Trac] #32907: We should pass the site ID to the 'wpmu_update_blog_options' action

[WordPress Trac]

#32907: We should pass the site ID to the 'wpmu_update_blog_options' action
---------------------------------------------+-----------------------------
 Reporter:  DrewAPicture                     |       Owner:  jeremyfelt
     Type:  defect (bug)                     |      Status:  reviewing
 Priority:  normal                           |   Milestone:  4.4
Component:  Options, Meta APIs               |     Version:  3.0
 Severity:  normal                           |  Resolution:
 Keywords:  good-first-bug has-patch commit  |     Focuses:  docs,
                                             |  multisite
---------------------------------------------+-----------------------------
Changes (by jeremyfelt):

 * keywords:  good-first-bug has-patch commit 4.4-early => good-first-bug
     has-patch commit
 * owner:  swissspidy => jeremyfelt
 * status:  assigned => reviewing
 * milestone:  Future Release => 4.4


Comment:

 Replying to [comment:10 swissspidy]:
 > In the same file `$id` is passed to the `wpmueditblogaction` action.
 Since `$id` is already available, I don't really see a benefit of using
 `get_current_blog_id()` instead. But there's a patch for either scenario.

 Yeah, I was thinking more along the lines of whether passing the ID was
 necessary because you can use `get_current_blog_id()` in your hooked
 function because things are currently switched. We have to pass `$id` to
 `wpmueditblogaction` because things are back to the network's site
 context.

 I do think the argument for clarity works as it would unify the two a bit.
 I'll take a look at getting this in.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32907#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform