[wp-trac] [WordPress Trac] #33417: JS error when uploading small image as Site Icon and electing to Skip Cropping (was: Js error when skip sropping)

[WordPress Trac]

#33417: JS error when uploading small image as Site Icon and electing to Skip
Cropping
--------------------------+-------------------------
 Reporter:  truonght      |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.3.1
Component:  Customize     |     Version:  4.3
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:  javascript
--------------------------+-------------------------
Changes (by westonruter):

 * keywords:  reporter-feedback => needs-patch
 * focuses:   => javascript
 * milestone:  Awaiting Review => 4.3.1


Old description:

> I select file in Customize > Site identity > Site icon. After select
> image, i choose skip cropping then popup has changed to blank. I see an
> eror in browse console:
> Uncaught TypeError: Cannot read property 'url' of undefined in load-
> scripts.php line 9

New description:

 I select a _small_ image in Customize > Site identity > Site icon. After
 selecting the image, I choose “Skip Cropping” and then the modal changes
 to blank. I see an error in browse console:

 > Uncaught TypeError: Cannot read property 'url' of undefined

--

Comment:

 Thank you. I was able to reproduce the issue once I tried a _small_ image.

 The error is happening in the `SiteIconControl.setImageFromAttachment()`
 method on this line:

 {{{#!js
 $( 'link[sizes="32x32"]' ).attr( 'href', icon.url );
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33417#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform