[wp-trac] [WordPress Trac] #33361: "Edit Comment" metabox header styling is inconsistent with others

[WordPress Trac]

#33361: "Edit Comment" metabox header styling is inconsistent with others
-----------------------------+---------------------------------
 Reporter:  johnjamesjacoby  |       Owner:  rachelbaker
     Type:  defect (bug)     |      Status:  accepted
 Priority:  normal           |   Milestone:  4.4
Component:  Comments         |     Version:
 Severity:  minor            |  Resolution:
 Keywords:  has-patch        |     Focuses:  ui, administration
-----------------------------+---------------------------------

Comment (by johnjamesjacoby):

 Replying to [comment:8 helen]:
 > Why do we need a redundant `h3`? There's no collapse or drag for this
 not-really-a-post-box, so it seems unnecessary...
 Because that's the tag all metaboxes use, draggable or not.

 > and will cause a double read out for screen readers and a second
 navigation landmark.
 I agree this is not ideal. Because `fieldset` elements cannot omit the
 `legend` element, barring a rewrite of the `fieldset` contents, this was
 my compromise.

 > I agree that the spacing is still off, but I don't see any need for more
 markup changes here.
 Normalizing metabox header markup removes this 1 hidden gotcha (rather
 than introducing more hidden gotchas to support the unique markup with
 unique CSS) while also bringing it up to par visually with the rest of
 WordPress. This entire screen is a bit of a sore thumb; my suggestion is
 to patch it, not cut it off, replace it, or leave it more sore than I
 found it.

 > The changeset you referenced was for #31326, which was markup changes
 for accessibility concerns.
 I understand; we all have the same annotations. I was just noting the most
 recent activity to that line to make the jaunt down memory lane a few
 clicks easier.

 I'm fuzzy on what you're suggesting happens next. The attached patches are
 a visual improvement that negatively impact accessibility in a relatively
 minor way. The way I see it, our options are to:
 * Commit the patch and iterate on the a11y later
 * Iterate on the patch and spend a bunch more time on a 3 line change
 * Do nothing until these boxes get a full a11y treatment
 * Turn comments off everywhere by default forever and declare success over
 the internet

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33361#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform