[wp-trac] [WordPress Trac] #28637: get_theme_mod returns empty string instead of default
WordPress Trac
noreply at wordpress.org
Wed Aug 19 17:44:30 UTC 2015
#28637: get_theme_mod returns empty string instead of default
----------------------------------------+-----------------------------
Reporter: philipjohn | Owner: valendesigns
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 4.4
Component: Customize | Version: 3.9.1
Severity: normal | Resolution:
Keywords: has-patch needs-unit-tests | Focuses: administration
----------------------------------------+-----------------------------
Changes (by valendesigns):
* keywords: has-patch => has-patch needs-unit-tests
* owner: => valendesigns
* status: new => assigned
Comment:
I think there should be some unit tests or at the very least more
discussion on potential side effects. Just returning false instead of an
empty sting may cause confusion in current implementations. We should
acknowledge any edge cases or competing perceptions before committing.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/28637#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list