[wp-trac] [WordPress Trac] #32876: Wrong data type for term taxonomy ID variable

[WordPress Trac]

#32876: Wrong data type for term taxonomy ID variable
-------------------------------------+------------------
 Reporter:  ipm-frommen              |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  4.4
Component:  Taxonomy                 |     Version:  2.3
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+------------------
Changes (by boonebgorges):

 * keywords:  has-patch needs-testing 2nd-opinion => has-patch needs-testing
 * milestone:  Awaiting Review => 4.4


Comment:

 I've just looked through a couple dozen plugins in the w.org plugin
 repository that look at the return value of `wp_update_term()` (`$ ack "\=
 *wp_update_term"`). I found zero plugins that would be affected by the
 change. In fact, I found zero plugins that looked at the
 'term_taxonomy_id' value *at all* - the vast majority of plugins are
 checking `is_wp_error()`, and a few look at `'term_id'`. I say we make the
 change. [attachment:32876.2.patch] contains a unit test. johnbillion, you
 have strong feelings about it?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32876#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform