[wp-trac] [WordPress Trac] #33358: Passwords: Second param of wp_new_user_notification() has been removed

[WordPress Trac]

#33358: Passwords: Second param of wp_new_user_notification() has been removed
-------------------------------------+--------------------------
 Reporter:  ocean90                  |       Owner:  markjaquith
     Type:  defect (bug)             |      Status:  reviewing
 Priority:  normal                   |   Milestone:  4.3
Component:  Users                    |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+--------------------------

Comment (by ocean90):

 Replying to [comment:5 markjaquith]:
 > @ocean90 what's the thought behind 'both' ? Why not just have it be a
 boolean `$email_user` flag?

 Mainly because of this http://make.wordpress.org/core/handbook/best-
 practices/coding-standards/php/#self-explanatory-flag-values-for-function-
 arguments.

 I think we need to take a step back here first:
 * Was it a good idea to change a pluggable function like this?
 * Shouldn't we introduce a new function instead?
 * If not, can we reuse the second param like we want to do or do we have
 to introduce a third one?
 * Or can we change it to $args[] and do a type check?
 * [https://gist.github.com/helenhousandi/da52b2905c3e0cebf6db How are
 plugins using this function?] (Thanks Helen for the list.)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33358#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform