[wp-trac] [WordPress Trac] #33365: Plugins admin: plugin-install.js prevents custom thickbox implementations

[WordPress Trac]

#33365: Plugins admin: plugin-install.js prevents custom thickbox implementations
----------------------------------------+-----------------------------
 Reporter:  Offereins                   |      Owner:
     Type:  defect (bug)                |     Status:  new
 Priority:  normal                      |  Milestone:  Awaiting Review
Component:  Plugins                     |    Version:  4.2
 Severity:  normal                      |   Keywords:
  Focuses:  javascript, administration  |
----------------------------------------+-----------------------------
 In [https://core.trac.wordpress.org/browser/trunk/src/wp-admin/js/plugin-
 install.js wp-admin/js/plugin-install.js] '''all thickbox links''' on the
 current page are given specific width and height values to fit the screen
 nicely. In addition, all thickbox links within the `plugin_row_meta` are
 manipulated, assuming they '''all''' are the Plugin Details iframe popup.

 When one wants to use a custom thickbox, either in the `plugin_row_meta`
 or elsewhere on the same page, it requires superfluous javascript to undo
 these manipulations. There is no easy way - or my js-skills are lacking -
 to do this. Targeting the proper links in the script, and not assuming all
 thickbox links are equal, would easily solve this issue.

 I suggest to add a `.plugin-details` class to all thickbox links that open
 the Plugin Details popup, and target those links in the script with
 `a.thickbox.plugin-details` accordingly. This would count for the (all?)
 pages where the script is loaded, which are:

 * wp-admin\import.php
 * wp-admin\index.php
 * wp-admin\network\index.php
 * wp-admin\plugin-install.php
 * wp-admin\plugins.php
 * wp-admin\update-core.php

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33365>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform