[wp-trac] [WordPress Trac] #33187: Menu becomes empty after saving in WordPress 4.2.3

[WordPress Trac]

#33187: Menu becomes empty after saving in WordPress 4.2.3
------------------------------+-----------------------------
 Reporter:  jcexygy           |       Owner:  boonebgorges
     Type:  defect (bug)      |      Status:  reviewing
 Priority:  high              |   Milestone:  4.3
Component:  Taxonomy          |     Version:  4.2
 Severity:  major             |  Resolution:
 Keywords:  has-patch commit  |     Focuses:  administration
------------------------------+-----------------------------

Comment (by boonebgorges):

 Replying to [comment:10 dd32]:
 > I think [attachment:33187.2.diff] works around that issue, and includes
 calling `exit()` after `wp_redirect()` which was missing in the earlier
 patch.
 >
 > One thing worth noting is that this all causes the `$messages` to be
 ignored, which are probably just `Menu X updated`, but could also include
 error messages or something ''I think''.

 Thanks, dd32. Yes, `$messages` will be lost. And it's possible that
 `$messages` will contain error messages, though it looks like it'll only
 happen when data is corrupt (like, a nav item has been deleted manually
 from wp_posts during a race condition). Given that the redirect is going
 to be tripped in such a small number of installs (those with a shared menu
 term), and on those installs it'll happen just one time and never again,
 I'm OK with this limitation.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33187#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform