[wp-trac] [WordPress Trac] #30261: Split all existing shared taxonomy terms on WP upgrade

[WordPress Trac]

#30261: Split all existing shared taxonomy terms on WP upgrade
-------------------------------------+---------------------------
 Reporter:  boonebgorges             |       Owner:  boonebgorges
     Type:  enhancement              |      Status:  reopened
 Priority:  high                     |   Milestone:  4.3
Component:  Taxonomy                 |     Version:
 Severity:  blocker                  |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+---------------------------

Comment (by dd32):

 The major thing that springs to mind here with the retrying, is that the
 back-compat option `_split_terms` will become invalid/only partially
 filled if the process dies part-way (It'll contain the last successful
 runs data).

 If no users on a site have the update_core capability (say because it's
 disabled as the site is using version control), and the loopback HTTP
 request fails, then the split term functionality won't be run then either.

 I'm really curious if we can just remove `WP_INSTALLING` from the upgrade
 routines instead and just have it work how we expected, the only thing I
 can see is that it'll cause `get/update_option()` to utilise the cache
 (and update the caches).
 That won't help with retrying the upgrade though, and I fear it'll cause
 some kind of unexpected behaviour in a plugin somewhere..


 I'm hoping that the number of shared terms on sites is actually fairly
 low, we only see a handful of reports of shared-term bugs, so it's bound
 to be a small percentage of sites.. which is why I'm hoping that having to
 deal with retrying the process could possibly be dealt with later..

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30261#comment:34>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform