[wp-trac] [WordPress Trac] #33184: Customizer: unnecessary events bound on some section titles

WordPress Trac noreply at wordpress.org
Tue Aug 11 23:23:39 UTC 2015


#33184: Customizer: unnecessary events bound on some section titles
--------------------------+----------------------------------------
 Reporter:  afercia       |       Owner:  helen
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  4.3
Component:  Customize     |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  accessibility, javascript
--------------------------+----------------------------------------

Comment (by valendesigns):

 I've made it so the `.customizer-screen-options-toggle` works with
 spacebar and enter in [attachment:33184.8.diff]. And as far as I can tell,
 all the other places of concern currently work with spacebar and enter.
 Both `.customize-help-toggle` & `.clear-results` are working for me in FF
 & Chrome. What is the issue beyond making spacebar and enter work? Do we
 really need to concern ourselves with mitigating all the unused events at
 this time if we can fix this a different way? I also fixed the search
 results for mobile.

 IMHO we don't need to change all that CSS and JS this far into the
 release, it's just to late for that. What we can do is fix the issues with
 a different less invasive approach, but most of the issues are already in
 a working state from my perspective. Based on comment:3 & comment:12 I
 feel that [attachment:33184.8.diff] is a good start or possibly end to
 solving what remains without changing the markup & CSS.

 Please test and verify.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33184#comment:31>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list