[wp-trac] [WordPress Trac] #33326: Site Icon: Check return of wp_get_attachment_image_src in get_site_icon_url

[WordPress Trac]

#33326: Site Icon: Check return of wp_get_attachment_image_src in get_site_icon_url
------------------------------------------+-----------------------
 Reporter:  MikeHansenMe                  |       Owner:  obenland
     Type:  defect (bug)                  |      Status:  accepted
 Priority:  normal                        |   Milestone:  4.3
Component:  Customize                     |     Version:  trunk
 Severity:  normal                        |  Resolution:
 Keywords:  has-patch commit ux-feedback  |     Focuses:
------------------------------------------+-----------------------
Changes (by mrahmadawais):

 * keywords:  has-patch commit => has-patch commit ux-feedback


Comment:

 Replying to [comment:9 obenland]:

 By the way, the site icon can be more optimized to support more platforms,
 let me know if I can create a patch.

 Here is what my optimized fav icon's code looks like in a web project.


 {{{

 <link rel="apple-touch-icon" sizes="57x57" href="/images/apple-touch-icon-
 57x57.png">
 <link rel="apple-touch-icon" sizes="60x60" href="/images/apple-touch-icon-
 60x60.png">
 <link rel="apple-touch-icon" sizes="72x72" href="/images/apple-touch-icon-
 72x72.png">
 <link rel="apple-touch-icon" sizes="76x76" href="/images/apple-touch-icon-
 76x76.png">
 <link rel="apple-touch-icon" sizes="114x114" href="/images/apple-touch-
 icon-114x114.png">
 <link rel="apple-touch-icon" sizes="120x120" href="/images/apple-touch-
 icon-120x120.png">
 <link rel="apple-touch-icon" sizes="144x144" href="/images/apple-touch-
 icon-144x144.png">
 <link rel="apple-touch-icon" sizes="152x152" href="/images/apple-touch-
 icon-152x152.png">
 <link rel="apple-touch-icon" sizes="180x180" href="/images/apple-touch-
 icon-180x180.png">
 <link rel="icon" type="image/png" href="/images/favicon-32x32.png"
 sizes="32x32">
 <link rel="icon" type="image/png" href="/images/favicon-194x194.png"
 sizes="194x194">
 <link rel="icon" type="image/png" href="/images/favicon-96x96.png"
 sizes="96x96">
 <link rel="icon" type="image/png" href="/images/android-chrome-
 192x192.png" sizes="192x192">
 <link rel="icon" type="image/png" href="/images/favicon-16x16.png"
 sizes="16x16">
 <link rel="manifest" href="/images/manifest.json">
 <meta name="msapplication-TileColor" content="#2c2c2c">
 <meta name="msapplication-TileImage" content="/images/mstile-144x144.png">
 <meta name="theme-color" content="#ffffff">
 }}}



 This supports iOS and Android Bookmarks as well as Win 8 Tiles.

 Compatible with:

 - Windows (IE, Chrome, Firefox, Opera, Safari)
 - Mac (Safari, Chrome, Firefox, Opera, Camino)
 - iOS (Safari, Chrome, Coast)
 - Android (Chrome, Firefox)
 - Surface (IE)



 Looking forward.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33326#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform