[wp-trac] [WordPress Trac] #33334: (Shared term) Nav menu cleared on save

[WordPress Trac]

#33334: (Shared term) Nav menu cleared on save
---------------------------+-----------------------------
 Reporter:  TannerMirabel  |      Owner:
     Type:  defect (bug)   |     Status:  new
 Priority:  normal         |  Milestone:  Awaiting Review
Component:  Menus          |    Version:  trunk
 Severity:  normal         |   Keywords:
  Focuses:                 |
---------------------------+-----------------------------
 We ran into this bug with some earlier installations where there were
 shared taxonomy terms.

 I have reproduced this in WP 4.2.4 network installation.

 Steps to reproduce:
 1. In your database, have terms that are shared between multiple
 taxonomies with one taxonomy being `nav_menu`.
 2. Populate said menu and save changes.

 Expected result would be that the changes were updated to the menu but
 instead the menu items disappear.

 I suspect this is because the menu's `term_id` is changed and its items
 are not coupled with the new ID.

 If this is the case, it could be fixed beforehand by splitting the terms
 with something like this: https://github.com/jjeaton/wp-find-shared-terms.
 It tried this on a test environment and it seemed to work nicely.

 In our case, we have dozens of network installations with dozens of sites
 in each so it's not possible for us to go through each site to detect and
 fix menus with possible shared taxonomies.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33334>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform