[wp-trac] [WordPress Trac] #33326: Site Icon: Check return of wp_get_attachment_image_src in get_site_icon_url

[WordPress Trac]

#33326: Site Icon: Check return of wp_get_attachment_image_src in get_site_icon_url
------------------------------+-----------------------
 Reporter:  MikeHansenMe      |       Owner:  obenland
     Type:  defect (bug)      |      Status:  accepted
 Priority:  normal            |   Milestone:  4.3
Component:  Customize         |     Version:  trunk
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:
------------------------------+-----------------------

Comment (by azaozz):

 33326.diff looks good. However, why do we have `if ( function_exists(
 'get_blog_option' ) )` at the top of `get_site_icon_url()`? Shouldn't that
 be `is_multisite()`?

 Generally `function_exists()` is slow, we don't want it running on every
 front-end page load.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33326#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform