[wp-trac] [WordPress Trac] #33326: Site Icon: Check return of wp_get_attachment_image_src in get_site_icon_url

[WordPress Trac]

#33326: Site Icon: Check return of wp_get_attachment_image_src in get_site_icon_url
-------------------------------------+-----------------------
 Reporter:  MikeHansenMe             |       Owner:  obenland
     Type:  defect (bug)             |      Status:  accepted
 Priority:  normal                   |   Milestone:  4.3
Component:  Customize                |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-refresh  |     Focuses:
-------------------------------------+-----------------------
Changes (by swissspidy):

 * keywords:  has-patch => has-patch needs-refresh


Comment:

 It's considered bad practice to have assignments in an if condition.
 Prohibited by the WP coding standards.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33326#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform