[wp-trac] [WordPress Trac] #33311: TB_window spinner should probably disappear when loading is done

[WordPress Trac]

#33311: TB_window spinner should probably disappear when loading is done
-------------------------------------------------+-------------------------
 Reporter:  niklasbr                             |      Owner:
     Type:  enhancement                          |     Status:  new
 Priority:  normal                               |  Milestone:  Awaiting
Component:  Plugins                              |  Review
 Severity:  normal                               |    Version:  4.2.4
  Focuses:  ui, javascript, administration,      |   Keywords:
  performance                                    |
-------------------------------------------------+-------------------------
 == Background ==
 Some third-party WordPress services such as Gravity Forms or WPMU Dev
 supply their own source for the "View version X.Y details" ThickBox
 content. Unlike WordPress.org this supplied content does not always
 specify a background colour or background image for the loaded content.

 This results in a visible spinner which continues to spin after all
 content has been properly loaded. This is most visible on very small
 screens where the spinned can interfere with the content above it (a from
 a z layering perspective) or very large screens where the spinner can
 again be visible below (a y axis perspective) the content.

 == Two ideas for possible solutions ==

 A. Update the [http://codex.wordpress.org/ThickBox documentation] for the
 ThickBox to specify that the spinner need to be covered or removed.
 However, this is not optimal because something that can be fixed with code
 will fix the issue for everyone, not everyone will read updated
 documentation (unless there is a deprecation message).

 B. Use a callback to add or remove a class which controls the spinner to
 ''#TB_window'' which removes the animated gif. I would prefer this
 solution because this would decrease energy usage (by a small amount,
 sure, but still) because the spinner is always animating, even when it is
 obscured by other elements, constantly redrawing/recompositing the
 content.

 I will be attaching two files, one is a screen shot showing the effect
 with Gravity Form's update dialogue (third-party iframe source). The other
 file is a screen recording of Yoast SEO (WordPress.org iframe source)
 using Firefox's [https://developer.mozilla.org/en-
 US/docs/Tools/Paint_Flashing_Tool Paint Flashing Tool] demonstrating the
 effect of removing the animated image on resource usage.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33311>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform