[wp-trac] [WordPress Trac] #33184: Customizer: unnecessary events bound on some section titles
WordPress Trac
noreply at wordpress.org
Fri Aug 7 15:37:58 UTC 2015
#33184: Customizer: unnecessary events bound on some section titles
------------------------------+----------------------------------------
Reporter: afercia | Owner: helen
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 4.3
Component: Customize | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch commit | Focuses: accessibility, javascript
------------------------------+----------------------------------------
Comment (by afercia):
The `itemSectionHeight()` calculation is wrong now, since the HTML/CSS has
changed a bit. Though it's unrelated to the events stuff, would need some
tweaking. Will leave the decision to committers of course :) Also, it
would be better to get rid of the "magic numbers" there for at least a
couple of reasons:
- any future CSS change might change the accordion sections height
breaking the calculation based on magic numbers
- very long accordion section titles (custom post types, translations)
might break in two lines and the accordion sections height wouldn't be
"46" anymore
The refreshed patch refactors `itemSectionHeight()` and includes a fix for
IE 8 that doesn't support `window.innerHeight`.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/33184#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list