[wp-trac] [WordPress Trac] #33259: Inconsistent KSES Shortcode Result

[WordPress Trac]

#33259: Inconsistent KSES Shortcode Result
--------------------------+--------------------------
 Reporter:  miqrogroove   |       Owner:  miqrogroove
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  4.3
Component:  Shortcodes    |     Version:  4.2.3
 Severity:  minor         |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+--------------------------

Comment (by ocean90):

 [attachment:33259.2.diff] works for me.

 Without the change to `trim( $new_attr `) the test fails with

 {{{
 1) Tests_Shortcode::test_escaping with data set #2 ('1 <a noise="[test-
 shortcode-tag]"> 2 <a noise=" [test-shortcode-tag] " >', '1 <a noise
 ="[test-shortcode-tag]"> 2 <a noise=" [test-shortcode-tag] " >')
 Failed asserting that two strings are equal.
 --- Expected
 +++ Actual
 @@ @@
 -'1 <a noise="[test-shortcode-tag]"> 2 <a noise=" [test-shortcode-tag] "
 >'
 +'1 <a noise="[test-shortcode-tag]"> 2 <a  >'

 /srv/www/wp-develop/svn/tests/phpunit/tests/shortcode.php:412
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33259#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform