[wp-trac] [WordPress Trac] #33220: Customizer: layout issues with autofocus'd sections on small screens

WordPress Trac noreply at wordpress.org
Thu Aug 6 19:43:19 UTC 2015


#33220: Customizer: layout issues with autofocus'd sections on small screens
--------------------------+---------------------------
 Reporter:  mattwiebe     |       Owner:  valendesigns
     Type:  defect (bug)  |      Status:  reviewing
 Priority:  normal        |   Milestone:  4.3
Component:  Customize     |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  ui
--------------------------+---------------------------
Changes (by westonruter):

 * keywords:  needs-patch => has-patch


Comment:

 OK, [attachment:33220.4.diff] implements a change which ensures that
 setting the `active` state for a panel/section/control when the preview
 iframe is loading will result in a visibility toggle with a 0 duration.
 This ensures that the height can be calculated properly when the
 autofocusing kicks in. I'm not sure why autofocusing wasn't using this
 `activate()` method to begin with, as I recall this was the very scenario
 for why `onChangeActive` was calculating the duration as such in the first
 place:

 {{{#!js
 duration = ( 'resolved' === api.previewer.deferred.active.state() ?
 args.duration : 0 );
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33220#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list