[wp-trac] [WordPress Trac] #33184: Customizer: unnecessary events bound on some section titles

WordPress Trac noreply at wordpress.org
Wed Aug 5 16:16:02 UTC 2015


#33184: Customizer: unnecessary events bound on some section titles
--------------------------+----------------------------------------
 Reporter:  afercia       |       Owner:  helen
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  4.3
Component:  Customize     |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:  accessibility, javascript
--------------------------+----------------------------------------

Comment (by afercia):

 Refreshed patch, no new CSS classes.
 - refactored the available menu items template to move out the search from
 `.accordion-container`
 - JS: filter out the "titles" just for Panels, as far as I see there's no
 need to do the same for Sections
 - buttons should have a `type="button"` attribute so they don't need
 `preventDefault()`
 - buttons need just a `click` event and we can remove keys filtering

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33184#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list