[wp-trac] [WordPress Trac] #32529: wp-admin/includes files should not contain hooks

[WordPress Trac]

#32529: wp-admin/includes files should not contain hooks
----------------------------+-----------------------------
 Reporter:  wonderboymusic  |       Owner:  wonderboymusic
     Type:  enhancement     |      Status:  reopened
 Priority:  normal          |   Milestone:  4.3
Component:  Administration  |     Version:  trunk
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:
----------------------------+-----------------------------

Comment (by azaozz):

 Yeah, that works. Don't even need to include ms-admin-filters.php.

 Even simpler:
 {{{
 if ( ! function_exists( 'media_buttons' ) ) {
     include( ABSPATH . 'wp-admin/includes/media.php' );
     add_action( 'media_buttons', 'media_buttons' );
 }
 }}}

 The back-compat concern is mostly about plugins that include one of these
 wiles outside wp-admin. Also things like:
 https://core.trac.wordpress.org/browser/trunk/src/wp-
 includes/update.php#L198.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32529#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform