[wp-trac] [WordPress Trac] #32112: wp_get_attachment_url returns https when it should not

[WordPress Trac]

#32112: wp_get_attachment_url returns https when it should not
-------------------------------------+---------------------------
 Reporter:  zabatonni                |       Owner:  boonebgorges
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  4.2.2
Component:  Media                    |     Version:  4.2
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+---------------------------

Comment (by boonebgorges):

 Thanks for the thoughts, joemcgill.

 Another possible strategy is [attachment:32112.3.diff]. It copies the
 scheme logic from `get_home_url()`: match the scheme of the current
 request only when `! is_admin()` (and when we're not on the login page,
 though I'm not sure that's necessary here). Since posts are always created
 from the admin, this would take care of the problem of post content in the
 database.

 Your suggestion (2) and your TinyMCE suggestion are the "more focused
 patches" that I mention here
 https://core.trac.wordpress.org/ticket/32112#comment:17. Swapping out the
 `src` attribute in Visual mode is not too hard - I have a patch mostly
 done. Let's not worry about this on the current ticket though, as it's not
 a regression.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32112#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform