[wp-trac] [WordPress Trac] #31752: Add support for Reddit comment thread embeds?
WordPress Trac
noreply at wordpress.org
Thu Apr 30 01:45:37 UTC 2015
#31752: Add support for Reddit comment thread embeds?
-----------------------------+-------------------------
Reporter: bananastalktome | Owner:
Type: feature request | Status: closed
Priority: normal | Milestone:
Component: Embeds | Version:
Severity: minor | Resolution: maybelater
Keywords: | Focuses:
-----------------------------+-------------------------
Comment (by Viper007Bond):
One of their developers contacted me to let me know that oEmbed support
was added today: https://github.com/reddit/reddit/wiki/oEmbed
However for now they only support embedding comments, i.e. a URL that
looks like this:
https://www.reddit.com/r/Showerthoughts/comments/2safxv/we_should_start_keeping_giraffes_a_secret_from/cno7zic
Should we use regex to only match those supported URLs? Something like
this:
`#https?://(www\.)?reddit\.com/r/[^/]+/comments/[^/]+/[^/]+/.*#i`
Or should we just send all Reddit URLs to them and let unsupported URLs
get back a 404? The advantage of that is when they roll out support for
more embed types, we aren't required to update things on our end. The
drawback is we'd be making unneeded HTTP requests.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/31752#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list