[wp-trac] [WordPress Trac] #32154: Don't upgrade global tables for utf8mb4

WordPress Trac noreply at wordpress.org
Mon Apr 27 21:53:09 UTC 2015


#32154: Don't upgrade global tables for utf8mb4
--------------------------+--------------------
 Reporter:  ocean90       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.1.3
Component:  Database      |     Version:  4.2
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+--------------------

Comment (by johnjamesjacoby):

 IMO, we only want to run this once on any installation. I would suggest:

 * `is_main_site()`
 * `is_main_network()`

 Which means:

 {{{
 if ( is_main_site() && is_main_network() && ! defined(
 'DO_NOT_UPGRADE_GLOBAL_TABLES' ) ) {
 }}}

 Nacin mentioned concerns about pre-schema issues with `is_main_site()`.
 I'd noticed that `pre_schema_upgrade()` uses `is_main_network()` already
 for sign-up tables, but I'm uncertain if that influences things.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32154#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list