[wp-trac] [WordPress Trac] #31982: WordPress PHPUnit Tests should run error free on PHP7 - 4.3 tracking ticket

[WordPress Trac]

#31982: WordPress PHPUnit Tests should run error free on PHP7 - 4.3 tracking ticket
------------------------------+------------------
 Reporter:  jorbin            |       Owner:
     Type:  task (blessed)    |      Status:  new
 Priority:  normal            |   Milestone:  4.3
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |     Focuses:
------------------------------+------------------
Changes (by jdgrimes):

 * keywords:   => has-patch


Comment:

 [attachment:31982.diff] is the first pass at a patch for the PHP5
 constructors.

 Notes:
 - The `ftp` classes already had PHP5 constructors, but they were below the
 PHP4 constructors. This will give `PHP Strict Standards:  Redefining
 already defined constructor for class ftp_base`, so I've moved the PHP5
 constructors to above the PHP4 ones.
 - I've added basic docblocks to most of the constructors, with just a
 short description ("PHP5 constructor"/"PHP4 constructor").
 - I've update whitespace on most of the modified lines.
 - I've mostly used tabs to indent things, even though a few of the files
 are space-indented. If anyone wants to clean this up, they are welcome to
 it.
 - I've added the `public` keyword for many of the PHP4 constructors, some
 of which didn't have this before.
 - FWIW [attachment:PHP4ConstructorSniff.php] is the PHPCS sniff I used to
 generate the initial patch (though I've modified both it and the patch
 since).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31982#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform