[wp-trac] [WordPress Trac] #32086: AJAX plugin update says it updated when in reality it didn't
WordPress Trac
noreply at wordpress.org
Fri Apr 24 16:54:29 UTC 2015
#32086: AJAX plugin update says it updated when in reality it didn't
-------------------------------------+-----------------------------
Reporter: Viper007Bond | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 4.2.1
Component: Plugins | Version: 4.2
Severity: normal | Resolution:
Keywords: has-patch needs-testing | Focuses: administration
-------------------------------------+-----------------------------
Comment (by magicroundabout):
My concern with my patch is that `$this->result` will end up being the
result of the LAST update performed, which in the case of a shiny-update
is OK because there's only one of them, but may not be right for bulk
upgrades in general.
The alternative patch would be to use just `$result` on both lines 896 and
907.
BUT...the bigger question here is what should `Plugin_Upgrader->result` be
for a bulk update? (It seems to be used again in
`Plugin_Upgrader->plugin_info()` which `isn't used internally in the
class, but is called by the skins.` - at which point I'm out of my depth -
HELP!!)
--
Ticket URL: <https://core.trac.wordpress.org/ticket/32086#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list