[wp-trac] [WordPress Trac] #25143: Appending registered query vars to home URL sets is_home to true when should be false

[WordPress Trac]

#25143: Appending registered query vars to home URL sets is_home to true when
should be false
-------------------------------------+-----------------------
 Reporter:  mordauk                  |       Owner:
     Type:  defect (bug)             |      Status:  reopened
 Priority:  normal                   |   Milestone:  4.3
Component:  Query                    |     Version:  3.6
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+-----------------------
Changes (by boonebgorges):

 * keywords:  has-patch needs-testing 4.3-early => has-patch needs-testing
 * milestone:  Future Release => 4.3


Comment:

 [attachment:25143.5.patch] adds a little trick to 4.patch that ensures
 that anyone currently passing `null` to the function (probably no one, but
 hey) will continue to see the same behavior. I've also added some more
 explicit unit tests related to backward compatibility, and modified
 mordauk's original test to ensure that rewrite rules are flushed after
 registering the endpoint.

 Anyone want to take a look at this and make sure we haven't missed
 anything?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/25143#comment:31>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform