[wp-trac] [WordPress Trac] #32086: AJAX plugin update says it updated when in reality it didn't

[WordPress Trac]

#32086: AJAX plugin update says it updated when in reality it didn't
-------------------------------------+------------------------------
 Reporter:  Viper007Bond             |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Plugins                  |     Version:  4.2
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  administration
-------------------------------------+------------------------------
Changes (by mordauk):

 * keywords:   => has-patch needs-testing


Comment:

 This is happening because `$upgrader->bulk_upgrade( array( $plugin ) );`
 is still returning an array when a plugin fails to update. The `WP_Error`
 is returned as the plugin, so `$results[ $plugin ]` has to be checked for
 a `WP_Error`.

 [https://core.trac.wordpress.org/attachment/ticket/32086/32086.patch
 32086.patch] fixes this by adding in another `WP_Error` check inside of
 `if ( is_array( $result ) ) {` check.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32086#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform