[wp-trac] [WordPress Trac] #32082: Not accounting for Params in src in wp_video_shortcode

WordPress Trac noreply at wordpress.org
Thu Apr 23 17:42:19 UTC 2015


#32082: Not accounting for Params in src in wp_video_shortcode
--------------------------+-----------------------------
 Reporter:  cartpauj      |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Shortcodes    |    Version:  4.1.2
 Severity:  normal        |   Keywords:
  Focuses:                |
--------------------------+-----------------------------
 Trying to pass a src with URI params fails the ext matching here:
 https://core.trac.wordpress.org/browser/tags/4.1.2/src/wp-
 includes/media.php#L1761

 The issue is due to the regex in wp_check_filetype here:
 https://core.trac.wordpress.org/browser/tags/4.1.2/src/wp-
 includes/functions.php#L2052

 It needs to be changed to something like:
 {{{
 $ext_preg = '!\.(' . $ext_preg . ‘)(\?.*)?$!i';
 }}}


 Example src URL that fails:
 https://wordup.s3.amazonaws.com/99-right-curve-
 sequence.mp4?AWSAccessKeyId=KEY&Expires=1429813612&Signature=SIG

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32082>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list