[wp-trac] [WordPress Trac] #32053: Change title of collapse sidebar anchor when sidebar is collapsed

WordPress Trac noreply at wordpress.org
Wed Apr 22 16:01:10 UTC 2015

#32053: Change title of collapse sidebar anchor when sidebar is collapsed
 Reporter:  thorbrink     |       Owner:
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Customize     |     Version:  3.4
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:  ui, accessibility

Comment (by LewisCowles):

 > Tickets are closed when a commit is made to WordPress trunk to fix the
 issue, not when a patch is posted.

 I closed it because it seemed invalid, I was only following what I have
 watched you do, apologies if this was wrong, but it had nothing to do with
 the patch

 > The issue here is about screen readers / text-based navigation and how
 they explain the interaction to users with sight difficulty or otherwise
 use accessibility tools.

 Not the issue reported, but okay, then we need more details on a proposed
 remmedy don't we?

 I take on board that the code in-place was confusing and do thank Thor for
 pointing this out, hence my attempt to provide a middle-ground update via
 language file & php patch to show Thor how he could modify in either of
 those two places, neither patch is intended for the core, but AFAIK, I
 cannot just send Thor attachments; (Happy to learn if I can, but so far
 there seems to be some problem or another with anything I try to input to
 WordPress, none so far has given me many clues as to why...)

 > I have tested the first patch, customizer-toggle.php.patch, and it looks
 like a good solution and is working for me.

 Thanks for the feedback, apologies for any additional confusion.

 Basically WordPress has these language files, where we can change the
 text, as well as code files, where we can change a lookup string, so I
 would suggest a language change; rather than a core code change.

 I have provided how you could change the text in core file (.php patch),
 and language file (entire lang file, as I don't know too much about their
 process, or how that works).

 Making the text change when clicked or interacted with would likely
 require DOM changes, some interactive JS, and over-complicate the text,
 which was why I decided it might be best to just change the content to a
 more general language of "Toggle Sidebar" from "Sidebar Collapse" to see
 if that would be to your mind, clearer.

 There are other ways to make this more accessible, but not without
 changing the DOM code used, and even then I think it may break, so I
 posted the language file method immediately after posting a subtle change
 to the code (literally a string literal substitution, which AFAIK, changes
 the text, at least it did on my 4.1.2)

 Thanks all for feedback on my feedback from everyone, I am on #slack if
 anyone could give guidance on how to make this thing easier.

Ticket URL: <https://core.trac.wordpress.org/ticket/32053#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list