[wp-trac] [WordPress Trac] #28436: allowed_themes filter does not pass blog_id

[WordPress Trac]

#28436: allowed_themes filter does not pass blog_id
--------------------------------------+-----------------------------
 Reporter:  rmccue                    |       Owner:
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  Future Release
Component:  Themes                    |     Version:  3.4
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:  multisite
--------------------------------------+-----------------------------
Changes (by pento):

 * keywords:  needs-patch good-first-bug => good-first-bug has-patch


Comment:

 Nice! There are a few code style and comments that need tweaking:

 * The docs for the `allowed_themes_combined` and `allowed_themes_site`
 filters don't include `$blog_id`.
 * The `@since` for the `allowed_themes` filter should stay as "MU", not be
 updated to "4.2" (we can set the other filter versions correctly when this
 patch is accepted into core).
 * In the unit tests, you're backing up the `$wpdb->suppress_errors()`
 state, but this doesn't appear to be changed anywhere.
 * Is there any particular reason for setting `$_SERVER['REMOTE_ADDR']` in
 the unit tests?

 For props purposes, would you mind listing who is on the team at the
 Contributor Day?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28436#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform