[wp-trac] [WordPress Trac] #31964: Use a replaceable function for the beforeupload handler with shiny updates

[WordPress Trac]

#31964: Use a replaceable function for the beforeupload handler with shiny updates
-----------------------------+---------------------------------------------
 Reporter:  DavidAnderson    |       Owner:  jorbin
     Type:  enhancement      |      Status:  closed
 Priority:  low              |   Milestone:  4.2
Component:  Upgrade/Install  |     Version:  trunk
 Severity:  normal           |  Resolution:  fixed
 Keywords:  has-patch        |     Focuses:  ui, javascript, administration
  shiny-updates              |
-----------------------------+---------------------------------------------

Comment (by DavidAnderson):

 Thanks. All now seems good, on RC1. Phew!

 Just one bit of information you may need after WP 4.2 releases and if you
 get relevant reports... if:

 1) the user has a plugin installed that uses Yahnis Elsts' plugin updater
 class (most 3rd party plugins do - https://github.com/YahnisElsts/plugin-
 update-checker)
 2) and if the version of Yahnis' class is an older one

 Then:

 a) Only the first shiny update of a wordpress.org plugin will work.
 Subsequent ones fail. I traced this as far as discovering that only
 updates known via Yahnis' class would appear in the 'update_plugins'
 transient, after the first shiny update. Reproducible: every time

 b) A PHP warning will be output for every plugin using Yahnis' class on
 the plugins page. Reproducible: every time.

 Both these problems are resolved by updating to the current version of
 Yahnis' class. I have not bothered to bisect exactly which versions are
 affected, or to identify what the root cause is behind it.

 Summary: if after WP 4.2 you see reports of people for whom shiny updates
 after the first fail until they reload the plugin page, ask if they've got
 3rd party plugins. Probably the problem will disappear if they de-activate
 the 3rd party plugin.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31964#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform