[wp-trac] [WordPress Trac] #31964: Use a replaceable function for the beforeupload handler with shiny updates

[WordPress Trac]

#31964: Use a replaceable function for the beforeupload handler with shiny updates
-----------------------------+---------------------------------------------
 Reporter:  DavidAnderson    |       Owner:  jorbin
     Type:  enhancement      |      Status:  reopened
 Priority:  low              |   Milestone:  4.2
Component:  Upgrade/Install  |     Version:  trunk
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |     Focuses:  ui, javascript, administration
  shiny-updates              |
-----------------------------+---------------------------------------------
Changes (by DavidAnderson):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 The patch in #32126 does not work.

 The answer to @adamsilverstein's question - "Curious why you wrapped the
 function call in an an anonymous function wrapper (between patches 1 and
 2) - was that required?" - is "yes".

 This time I have verified that by actual, repeated testing... ;-)

 On my previous patch where I added the wrapper, it was very late in the
 day, I was very keen to get something into Trac before ending the day, and
 I added the wrapper based upon my understanding that variable referencing
 in JavaScript works as it does in PHP. Testing shows this to have been
 correct.

 New patch about to be attached...

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31964#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform