[wp-trac] [WordPress Trac] #31950: Reduce PHP memory usage / No unnecessary concatenation

[WordPress Trac]

#31950: Reduce PHP memory usage / No unnecessary concatenation
-----------------------------------+------------------------------
 Reporter:  jrf                    |       Owner:
     Type:  enhancement            |      Status:  new
 Priority:  normal                 |   Milestone:  Awaiting Review
Component:  General                |     Version:
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:  performance
-----------------------------------+------------------------------

Comment (by johnbillion):

 This is a strange change to propose without having actually done any
 performance tests. I would be quite surprised if this results in anything
 more than a negligible real-world reduction in memory usage, especially
 anywhere near 0.5%. It would be great if I'm wrong, of course!

 > The below files each contained an output string without localization
 function. Was there a reason for that ? I've wrapped them in a __() now.
 The error message in `wp-db.php` can occur before the localisation
 functions are available, which is why it's not wrapped in a call to
 `__()`. The other two look like they are indeed missed strings though. Can
 you open a separate ticket for those please?

 > For more information, see:
 > https://github.com/dseguy/clearPHP/blob/master/rules/no-unnecessary-
 string-concatenation.md
 > https://github.com/dseguy/clearPHP/blob/master/rules/no-repeated-
 print.md

 Those two "rules" conflict with each other. Which is it to be?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31950#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform