[wp-trac] [WordPress Trac] #31869: dbDelta doesn't allow for automatically truncated indexes

[WordPress Trac]

#31869: dbDelta doesn't allow for automatically truncated indexes
-----------------------------------+-----------------------
 Reporter:  pento                  |       Owner:  pento
     Type:  defect (bug)           |      Status:  assigned
 Priority:  normal                 |   Milestone:  4.2
Component:  Upgrade/Install        |     Version:
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 4.2-strings  |     Focuses:
-----------------------------------+-----------------------

Comment (by pento):

 I'm happy with the state of the the string in [attachment:31869.3.diff] -
 who knew that a one word change could make such a difference?

 My concern with the functionality of the patch is that it really only
 handles one specific case - when the CREATE TABLE statement doesn't
 specify a subpart, but MySQL shows that there is a subpart (most likely
 because it had to trim an index that was too long).

 Cases is doesn't handle:
 * When the CREATE TABLE has a subpart specified (say, you manually
 specified a subpart of 255, but MySQL trims it down because of utf8mb4)
 that differs from the subpart that MySQL shows.
 * When the CREATE TABLE has a subpart specified, but MySQL does not (I'm
 not sure how this would happen).

 I don't know if we need to handle those extra cases, though.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31869#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform