[wp-trac] [WordPress Trac] #31819: Shiny updates: more sophisticated locking

[WordPress Trac]

#31819: Shiny updates: more sophisticated locking
-------------------------------------+-------------------------------------
 Reporter:  DavidAnderson            |       Owner:  jorbin
     Type:  enhancement              |      Status:  closed
 Priority:  normal                   |   Milestone:  4.2
Component:  Upgrade/Install          |     Version:  trunk
 Severity:  normal                   |  Resolution:  fixed
 Keywords:  shiny-updates has-patch  |     Focuses:  ui, javascript,
  close                              |  administration
-------------------------------------+-------------------------------------

Comment (by DavidAnderson):

 @jorbin: OK... thanks for this. I've made some time to catch up.

 There were 3 things:

 1) The "update available" text being brought back when an update is
 cancelled via the backup dialog. This is now implemented - thank you.

 2) Using the new jQuery event instead of polling. This is also now
 implemented - thanks again.

 3) Not locking the queue, but instead intercepting the jQuery AJAX event,
 and then re-booting it. You said "Having the lock in place at the start is
 going to degrade the experience since we have the AYS check" - am I right
 in thinking that this is referring to the "do you want to close this
 page?" check (that's new - it wasn't there when I opened this ticket - am
 I right in thinking that?).
 Intercepting + replaying the AJAX event feels like a dirty low-level hack,
 whereas locking the queue feels like the right concept, if this "do you
 want to close?" check could be avoided. Also, the AJAX technique won't
 work well with bulk updates, as there's multiple AJAX calls then. (Though,
 I suppose I could try to detect when they're related/sequential...?).
 Though, currently, it looks like shiny updates have been disabled when
 using the "bulk updates" form - is that so? (I think I saw a Trac ticket
 somewhere mentioning it).

 Also - when I do multiple shiny updates, only the first succeeds.
 Subsequent ones fail. This is so with my code removed also, so it seems
 not to be related to anything I've done. My current WP version is
 4.2-beta4-32091.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31819#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform