[wp-trac] [WordPress Trac] #25143: Appending registered query vars to home URL sets is_home to true when should be false
WordPress Trac
noreply at wordpress.org
Thu Apr 9 22:28:15 UTC 2015
#25143: Appending registered query vars to home URL sets is_home to true when
should be false
-----------------------------------------------+---------------------------
Reporter: mordauk | Owner:
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: Future
Component: Query | Release
Severity: normal | Version: 3.6
Keywords: has-patch needs-testing 4.3-early | Resolution:
| Focuses:
-----------------------------------------------+---------------------------
Comment (by mordauk):
Replying to [comment:26 johnbillion]:
> It would make more sense to use the existing `$query_var` parameter for
this, rather than introducing a fourth parameter. It could accept boolean
false to disable the query var. With [attachment:25143.3.patch],
registering an endpoint with no query var requires that you pass in a
useless value to the `$query_var` parameter.
I wanted to take advantage of that but I'm not sure we can safely do that.
When `$query_var` is left empty, it defaults to the `$name` parameter. Too
many people register endpoints with just two parameters for us to safely
use that parameter.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/25143#comment:27>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list