[wp-trac] [WordPress Trac] #30725: Add media modal - different select width
WordPress Trac
noreply at wordpress.org
Thu Apr 9 02:08:33 UTC 2015
#30725: Add media modal - different select width
--------------------------+-----------------------
Reporter: pavelevap | Owner: helen
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: 4.2
Component: Media | Version: 4.1
Severity: minor | Resolution:
Keywords: needs-patch | Focuses: ui
--------------------------+-----------------------
Comment (by afercia):
Far from being perfect, attached refreshed patch tries to fix the selects
and the spinner position. Very, very, tricky:
- there's a mix of elements with fixed widths and percentage widths
- even using `calc()` we can't predict the width of some elements, for
example the "Bulk select" button width will vary depending on the
translation
Maybe the most sane things to do is to reserve additional space for longer
translations, as much as possible, and accept the fact elements will flow
in 2 or 3 lines on small screens.
There are still many edge cases, things may break. I'd consider this just
an attempt to patch a layout that should really be rebuilt from scratch.
We probably need to iterate on this. @helen please check carefully, any
change and improvements more than welcome.
Note: `url.js` needs some attention, the spinner isn't revealed when using
"Insert from URL".
--
Ticket URL: <https://core.trac.wordpress.org/ticket/30725#comment:43>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list