[wp-trac] [WordPress Trac] #31914: Remove static variable for global_terms_enable to allow for unit tests

[WordPress Trac]

#31914: Remove static variable for global_terms_enable to allow for unit tests
--------------------------+----------------------------------------------
 Reporter:  jeremyfelt    |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Future Release
Component:  Taxonomy      |    Version:  3.0
 Severity:  normal        |   Keywords:  has-patch 4.3-early dev-feedback
  Focuses:  multisite     |
--------------------------+----------------------------------------------
 From @boonebgorges in #31149:

     global_terms_enabled() stores the check in a static, which makes it
 impossible to toggle for the purposes of the unit tests. This was
 introduced in [14344] in what was, I assume, an attempt to optimize the
 function. @nacin do you have a problem if I roll this back and filter it
 every time the function is called? global_terms_enabled() is not called
 anywhere on the front end in core, and nowhere that I've found yet in the
 plugin repo, so I don't foresee any serious performance issues.

 [https://core.trac.wordpress.org/attachment/ticket/31149/31149.diff
 31149.diff] makes the necessary changes and adds unit tests to address
 #31149

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31914>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform