[wp-trac] [WordPress Trac] #31772: Browser unresponsive with long password

[WordPress Trac]

#31772: Browser unresponsive with long password
-------------------------------------+-------------------------------------
 Reporter:  BevanR                   |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Users                    |     Version:  3.7
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-unit-    |     Focuses:  javascript,
  tests                              |  performance
-------------------------------------+-------------------------------------
Changes (by jorbin):

 * keywords:  has-patch => has-patch needs-unit-tests


Comment:

 JavaScript tests are in
 [https://core.trac.wordpress.org/browser/trunk/tests/qunit tests/qunit]
 and the password strength meter is one area that we
 [https://core.trac.wordpress.org/browser/trunk/tests/qunit/wp-admin/js
 /password-strength-meter.js have decent coverage].  We can likely use
 sinon to add a spy into zxcvbn to make sure that only the first 128
 characters are being checked.

 Tests that rely upon certain time thresholds are harder to guarantee the
 results from since the machine running them can affect the results. We
 should avoid adding them.  Our JS suite is fairly good at avoiding false
 negatives and this is one area.

 Otherwise, this patch is looking good.  If we can get the tests in the
 next day or two, I think we may be able to add this to 4.2.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31772#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform