[wp-trac] [WordPress Trac] #31819: Shiny updates: more sophisticated locking
WordPress Trac
noreply at wordpress.org
Sat Apr 4 21:51:01 UTC 2015
#31819: Shiny updates: more sophisticated locking
-------------------------------------+-------------------------------------
Reporter: DavidAnderson | Owner: jorbin
Type: enhancement | Status: assigned
Priority: normal | Milestone: 4.2
Component: Upgrade/Install | Version: trunk
Severity: normal | Resolution:
Keywords: shiny-updates has-patch | Focuses: ui, javascript,
dev-feedback | administration
-------------------------------------+-------------------------------------
Comment (by ericlewis):
Chatting about this with @isuelde @helen and @DrewAPicture, here are some
thoughts.
Plugins should (try) not to depend on markup looking specific for critical
path functionality, as it is subject to change. Obviously, we should
balance this statement with our project's commitment to backwards
compatibility.
Also, if your goal is to perform a backup before upgrading a plugin, that
would be better handled in the PHP application layer rather than
triggering it via front-end user actions. This would remove the plugins'
dependency on the markup to take a particular form.
You could tap into the upgrade process via the
[https://github.com/WordPress/WordPress/blob/4.1.1/wp-admin/includes
/class-wp-upgrader.php#L356 upgrader_pre_install hook] and perform your
backup. This hook runs before every individual plugin upgrade.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/31819#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list