[wp-trac] [WordPress Trac] #25143: Appending registered query vars to home URL sets is_home to true when should be false

[WordPress Trac]

#25143: Appending registered query vars to home URL sets is_home to true when
should be false
-------------------------------------+-----------------------------
 Reporter:  mordauk                  |       Owner:
     Type:  defect (bug)             |      Status:  reopened
 Priority:  normal                   |   Milestone:  Future Release
Component:  Query                    |     Version:  3.6
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+-----------------------------

Comment (by mordauk):

 Replying to [comment:21 boonebgorges]:
 > Yeah, those workarounds are pretty unpleasant.
 >
 > > I do still think, however, that the behavior of setting is_home to
 true when any customer query var is present is wrong
 >
 > I think what I'm suggesting is that a `query_var`, by definition, should
 modify the query. If you don't want your URL params to modify the query,
 then don't register them as query vars. My solution would give you a way
 to use WP's rewrite goodies for your URL params without also having them
 be query vars.
 >
 Yep, I understood that :)

 Sounds like that would work fine for addressing the primary pain points
 here. I'll see if I can put together another patch for that.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/25143#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform