[wp-trac] [WordPress Trac] #31233: Dismissable admin notices

[WordPress Trac]

#31233: Dismissable admin notices
----------------------------+--------------------------------
 Reporter:  ryan            |       Owner:  helen
     Type:  task (blessed)  |      Status:  reopened
 Priority:  normal          |   Milestone:  4.2
Component:  Administration  |     Version:  4.1
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  ui, accessibility
----------------------------+--------------------------------

Comment (by valendesigns):

 @helen I've uploaded patch [attachment:31233.22.diff] to address your
 concerns.

 I've removed the change I made to the paragraph margins for now, as it's
 really only an issue in Firefox because the notice height is rounded up to
 39px where all the other browsers set it to 38px based on the combined
 heights of the contents, plus padding and margin. As well, you only notice
 the height difference when the focus state is on and since we've removed
 `:active` Firefox no longer shows that glow when you click the button.
 It's really not that critical, but to change the `.5em` margin equivalent
 to pixels means it would need to be `6.5px` and that still displays the
 same issue in Firefox. I say we revisit it later if it really bothers
 people. For now we just need to get the button looking fairly consistent.

 To remove `!important` I targeted the notice with `.wrap`which adds more
 specificity. Hope that works for you?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31233#comment:59>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform