[wp-trac] [WordPress Trac] #31769: Prevent navigating away while plugins are updating via shiny updates

[WordPress Trac]

#31769: Prevent navigating away while plugins are updating via shiny updates
-------------------------------------+-------------------------------------
 Reporter:  johnbillion              |       Owner:  johnbillion
     Type:  enhancement              |      Status:  reviewing
 Priority:  normal                   |   Milestone:  4.2
Component:  Upgrade/Install          |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  dev-feedback needs-      |     Focuses:  javascript,
  testing 4.2-strings has-patch      |  administration
  needs-refresh                      |
-------------------------------------+-------------------------------------

Comment (by adamsilverstein):

 I will update the patch and double check to make sure the lock is cleared
 if the update fails, that sounds right.

 I will also test in IE :)

 Replying to [comment:9 johnbillion]:
 > This doesn't clear the onbeforeunload event if an error occurs with a
 plugin update.
 >
 > It looks like `wp.updates.updateLock = false;` needs to be called in
 `wp.updates.updateError()` in the same way that it is in
 `wp.updates.updateSuccess()`, but I'm not overly familiar with this code.
 >
 > @jorbin @pento @adamsilverstein thoughts?
 >
 > Also patch needs a refresh to apply cleanly.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31769#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform